gtk4.git
11 years agoUdated Czech translation
Marek Černocký [Wed, 1 Apr 2015 09:55:02 +0000 (11:55 +0200)]
Udated Czech translation

11 years agoUpdated Slovenian translation
Matej Urbančič [Tue, 31 Mar 2015 19:09:21 +0000 (21:09 +0200)]
Updated Slovenian translation

11 years agoscrolledwindow: Remove needless "dragging" field from Indicator struct
Carlos Garnacho [Tue, 31 Mar 2015 11:13:50 +0000 (13:13 +0200)]
scrolledwindow: Remove needless "dragging" field from Indicator struct

The "over" state already stays set while scrollbar dragging happens, there's
no need to double track that.

https://bugzilla.gnome.org/show_bug.cgi?id=746961

11 years agoscrolledwindow: Check the event widget on captured motion events
Carlos Garnacho [Tue, 31 Mar 2015 11:01:34 +0000 (13:01 +0200)]
scrolledwindow: Check the event widget on captured motion events

This path is only intended to be triggered on events directed towards the
child of the scrolledwindow, so make it explicitly so. This avoids scrollbar
"over" state flashing when dragging finishes within the slider.

https://bugzilla.gnome.org/show_bug.cgi?id=746961

11 years agowayland: Set a more correct xdg_surface application id
Jonas Ådahl [Mon, 23 Mar 2015 05:08:09 +0000 (13:08 +0800)]
wayland: Set a more correct xdg_surface application id

The "app_id" of a xdg_surface should be the ID that can potentially be
used to get the DBUS name or the .desktop file.

For GtkApplication programs this is often the ID passed when creating the
GtkApplication object, so when available lets use that.

As fallbacks, first try g_get_prgname as it often corresponds to the
basename part of the .dektop file for non-GtkApplication programs.
Otherwise use gdk_get_program_class, even though that string usually
doesn't conform to the expectations of xdg_surface.set_application_id.

https://bugzilla.gnome.org/show_bug.cgi?id=746435

11 years agoUpdated Russian translation
Stas Solovey [Mon, 30 Mar 2015 22:40:20 +0000 (22:40 +0000)]
Updated Russian translation

11 years agoRevert "Adwaita: desaturate selected color for backdrop"
Jakub Steiner [Mon, 30 Mar 2015 12:54:25 +0000 (14:54 +0200)]
Revert "Adwaita: desaturate selected color for backdrop"

This reverts commit 6f478db2facd8744714b7ab374d2687d777653a3.

As per discussion on bug 746202, the real solution to the case
in bug 704352 is what the reporter suggests.

11 years agoUpdated Ukrainian translation
Daniel Korostil [Mon, 30 Mar 2015 05:52:44 +0000 (08:52 +0300)]
Updated Ukrainian translation

11 years agogtkdnd: Restore widget opacity after fading out
Carlos Garnacho [Sat, 28 Mar 2015 15:22:09 +0000 (16:22 +0100)]
gtkdnd: Restore widget opacity after fading out

Otherwise the widget is left fully transparent, and will start as such if
the widget is reused.

11 years agogtkdnd: Set the icon helper from the drag site onto the context
Carlos Garnacho [Sat, 28 Mar 2015 13:16:45 +0000 (14:16 +0100)]
gtkdnd: Set the icon helper from the drag site onto the context

If the icon happened to come from the drag site icon helper (ie. set through
gtk_drag_source_set_icon*), it would be referenced on the GtkDragInfo,
but not hooked into its context. This results on non visible drag windows,
until set_icon_helper() happened to be called on some path.

11 years agoroundedbox: Fix a copy/paste error
Benjamin Otte [Sun, 29 Mar 2015 20:16:14 +0000 (22:16 +0200)]
roundedbox: Fix a copy/paste error

This caused shadows to not be drawn in certain situations when overlayed
via a popover animation.

https://bugzilla.gnome.org/show_bug.cgi?id=746862

11 years agoUpdated Czech translation
Marek Černocký [Sun, 29 Mar 2015 11:49:43 +0000 (13:49 +0200)]
Updated Czech translation

11 years agoradio button: Fix directional navigation
Matthias Clasen [Sun, 29 Mar 2015 04:24:35 +0000 (00:24 -0400)]
radio button: Fix directional navigation

GtkRadioButton had a deficient copy of the focus sort code
in GtkContainer, causing focus to jump over the next button
in the list. Just use _gtk_container_focus_sort() here,
which fixes the bug _and_ saves 80 lines of code.

https://bugzilla.gnome.org/show_bug.cgi?id=746817

11 years agoFix separator in testsplitheaders
Matthias Clasen [Sun, 29 Mar 2015 02:32:12 +0000 (22:32 -0400)]
Fix separator in testsplitheaders

11 years agogtkprogressbar: fix size allocation
Lars Uebernickel [Tue, 24 Mar 2015 13:25:49 +0000 (14:25 +0100)]
gtkprogressbar: fix size allocation

As of 74405cc, progress bars use a new design with values drawn on top
(or to the left) of the through instead of inside of it. This change
brought a number of regressions: the min-horizontal-bar-height and
min-vertical-bar-width style properties are not respected anymore. For
vertical progress bars, the value was drawn too close to the bar and not
centered vertically.

Fix this by respecting the style properties and drawing the value label
at the correct position.

Also, the xspacing and yspacing properties didn't server any apparent
purpose. Change their semantics to mean "the spacing between the label
and the bar". Hence, they only need to be added to the size request when
showing the label. Since we are changing semantics anyway, reduce their
default values from 7 to 2, to avoid and excessive gap.

https://bugzilla.gnome.org/show_bug.cgi?id=746688

11 years agomake libcanberra support optional
Antoine Jacoutot [Fri, 27 Mar 2015 18:04:20 +0000 (19:04 +0100)]
make libcanberra support optional

Make it possible to control libcanberra support so we don't risk ending up with
a cyclic dependency when using packages: gtk+ -> libcanberra-gtk3 -> gtk+

https://bugzilla.gnome.org/show_bug.cgi?id=746904

11 years agoUpdated Slovenian translation
Matej Urbančič [Sat, 28 Mar 2015 21:42:42 +0000 (22:42 +0100)]
Updated Slovenian translation

11 years agoUpload Catalan translation
Jordi Mas [Sat, 28 Mar 2015 12:36:25 +0000 (13:36 +0100)]
Upload Catalan translation

11 years agoGtkListBox: fix model binding refcount issue
Ryan Lortie [Fri, 27 Mar 2015 15:57:38 +0000 (11:57 -0400)]
GtkListBox: fix model binding refcount issue

As it is, GtkListBox model binding will work nicely as long as your
create_widget_func returns a floating reference on the newly-created
widget.

If you try to return a full reference (as any higher-level language
would do) then you will leak that reference.

Fix that up by converting any floating references into full references
and then unconditionally releasing the full reference after adding to
the box.

https://bugzilla.gnome.org/show_bug.cgi?id=746893

11 years agoscrolledwindow: Extend trackpoint heuristic to ALPS trackpoints
Hans de Goede [Thu, 26 Mar 2015 18:46:56 +0000 (19:46 +0100)]
scrolledwindow: Extend trackpoint heuristic to ALPS trackpoints

These have a different characteristic device name, look for it too
in order to enable trackpoint features.

11 years agodocs: Add initialization example for GtkGLArea
Emmanuele Bassi [Thu, 26 Mar 2015 17:40:40 +0000 (17:40 +0000)]
docs: Add initialization example for GtkGLArea

Show how to safely check for errors when initializing the OpenGL
pipeline.

11 years agox11/gl: Do not use GLX_EXT_texture_from_pixmap if not available
Emmanuele Bassi [Thu, 26 Mar 2015 17:26:29 +0000 (17:26 +0000)]
x11/gl: Do not use GLX_EXT_texture_from_pixmap if not available

If the GLX_EXT_texture_from_pixmap extension is not available when we
did the extensions check, then there's no point in using the backend
specific code paths that rely on it.

11 years agoW32: Only override window miximized position for CSDed windows
Руслан Ижбулатов [Thu, 26 Mar 2015 17:01:59 +0000 (17:01 +0000)]
W32: Only override window miximized position for CSDed windows

This fixes an issue with non-CSDed windows being improperly positioned
when maximized, which was introduced by the previous commit.

https://bugzilla.gnome.org/show_bug.cgi?id=746821

11 years agoW32: Correctly set maximized window position
Руслан Ижбулатов [Thu, 26 Mar 2015 15:22:07 +0000 (15:22 +0000)]
W32: Correctly set maximized window position

Use screen workarea to *also* set the position of a maximized window,
not just its size. Without this the window position defaults to 0:0
(the topleft corner), which is wrong when taskbar is position along the
top or left edge of the screen.

https://bugzilla.gnome.org/show_bug.cgi?id=746821

11 years agobbox: correct documentation typo
Will Thompson [Sun, 23 Jun 2013 14:35:21 +0000 (15:35 +0100)]
bbox: correct documentation typo

11 years agoFix an AtkStateType emitted for GtkBooleanCellAccessible
Joanmarie Diggs [Wed, 25 Mar 2015 23:21:37 +0000 (19:21 -0400)]
Fix an AtkStateType emitted for GtkBooleanCellAccessible

An apparent copy-and-paste error is resulting in ATs being notified of
changes in ATK_STATE_CHECKED when the cell's "sensitive" state changes.

https://bugzilla.gnome.org/show_bug.cgi?id=746784

11 years agotextview: Fix "Since" versions after backport
Rico Tzschichholz [Wed, 25 Mar 2015 19:52:43 +0000 (20:52 +0100)]
textview: Fix "Since" versions after backport

Fix for 28063ee2e42e7ce47b7bd5326f2d53875a377d57 which got cherry-picked
to 3.16

11 years agodemo/glarea: Check errors on GtkGLArea
Emmanuele Bassi [Wed, 25 Mar 2015 15:20:36 +0000 (15:20 +0000)]
demo/glarea: Check errors on GtkGLArea

We should not call OpenGL API if GtkGLArea is in an error state.

https://bugzilla.gnome.org/show_bug.cgi?id=746746

11 years agoglarea: Check that the context is not NULL
Emmanuele Bassi [Wed, 25 Mar 2015 15:19:30 +0000 (15:19 +0000)]
glarea: Check that the context is not NULL

The public API should perform more checks when it comes to an NULL
context.

https://bugzilla.gnome.org/show_bug.cgi?id=746746

11 years agox11/gl: Do not try to call MakeCurrent with a NULL context
Emmanuele Bassi [Wed, 25 Mar 2015 15:18:44 +0000 (15:18 +0000)]
x11/gl: Do not try to call MakeCurrent with a NULL context

This should not happen, but better safe than sorry.

https://bugzilla.gnome.org/show_bug.cgi?id=746746

11 years agox11/gl: Trap GL context creation
Emmanuele Bassi [Wed, 25 Mar 2015 14:34:42 +0000 (14:34 +0000)]
x11/gl: Trap GL context creation

Avoid an X11 error in case the context creation fails, so we can avoid a
crash and pick it up in the upper layers, and display an error.

https://bugzilla.gnome.org/show_bug.cgi?id=746746

11 years agofilechooser: Use same priority everywhere
Benjamin Otte [Wed, 25 Mar 2015 03:27:33 +0000 (04:27 +0100)]
filechooser: Use same priority everywhere

I managed to stall recent files today while trying to save a GTK
testcase in glade that contained enough spinning spinners that the CPU
was saturated just redrawing things.

I had to navigate the filesystem!

11 years agoGtkRange: Check "inverted" property when drawing
Marcus Karlsson [Tue, 24 Mar 2015 21:14:27 +0000 (22:14 +0100)]
GtkRange: Check "inverted" property when drawing

The direction in which the slider moves can be inverted by setting the
inverted property. But the draw method does not check this, instead it
checks if the direction of the widget is set to be right to left.

Call the should_invert function in order to determine if the direction
of the range should be inverted. It too checks the widget's direction,
but also checks the "inverted" property, and allows the range to be
drawn inverted even if it is vertically oriented.

https://bugzilla.gnome.org/show_bug.cgi?id=746712

11 years agoa11y: Only emit name-changed once
Joanmarie Diggs [Wed, 25 Mar 2015 03:01:48 +0000 (04:01 +0100)]
a11y: Only emit name-changed once

We were emitting it twice, once with deleting the old text, once with
inserting the new text.

https://bugzilla.gnome.org/show_bug.cgi?id=746706

11 years agoa11y: Free the cell text after emitting text-changed:delete.
Joanmarie Diggs [Wed, 25 Mar 2015 03:00:20 +0000 (04:00 +0100)]
a11y: Free the cell text after emitting text-changed:delete.

This is needed because AT-SPI2's ATK bridge exposes the deleted string
to ATs.

https://bugzilla.gnome.org/show_bug.cgi?id=746706

11 years agoa11y: Refactor code
Joanmarie Diggs [Wed, 25 Mar 2015 02:57:45 +0000 (03:57 +0100)]
a11y: Refactor code

Put the equality check in front. This allows better detection of when an
insert or delete needs to be emitted.

Also, only emit text-changed:delete if the deleted text is not the empty
string. Only emit text-changed:insert if the inserted text is not the
empty string.

https://bugzilla.gnome.org/show_bug.cgi?id=746706

11 years agoa11y: Refactor textcellaccessible code
Joanmarie Diggs [Wed, 25 Mar 2015 02:54:19 +0000 (03:54 +0100)]
a11y: Refactor textcellaccessible code

Compute the new text and its length in advance. This way those
computations will not confuse us when they happen in the middle of the
actual action.

https://bugzilla.gnome.org/show_bug.cgi?id=746706

11 years agoGtkRange: Fix drawing of fill-level
Marcus Karlsson [Tue, 24 Mar 2015 21:31:52 +0000 (22:31 +0100)]
GtkRange: Fix drawing of fill-level

Compute the proportion of the range that should be filled to match the
fill level, and use it to compute the starting point and length of the
area between the slider and the fill level.

https://bugzilla.gnome.org/show_bug.cgi?id=734741

11 years agoinspector: fix warning about not using the right format for an int64
Ignacio Casal Quinteiro [Tue, 24 Mar 2015 12:34:10 +0000 (13:34 +0100)]
inspector: fix warning about not using the right format for an int64

11 years agocssnode: Clear widget path more aggressively
Benjamin Otte [Tue, 24 Mar 2015 03:14:28 +0000 (04:14 +0100)]
cssnode: Clear widget path more aggressively

When recomputing CSS, we need a correct widget path in the fallback mode
where we're still using widget paths.
So we need to invalidate it everytime it actually changes, and not just
when emitting the style-updated signal.

Fixes css-match-regions reftest.

11 years agoUpdated Korean translation
Changwoo Ryu [Tue, 24 Mar 2015 00:54:04 +0000 (09:54 +0900)]
Updated Korean translation

11 years agox11/gl: Removing some more legacy GL calls
Niels Nesse [Mon, 23 Mar 2015 22:15:08 +0000 (22:15 +0000)]
x11/gl: Removing some more legacy GL calls

They are not required any more.

http://bugzilla.gnome.org/show_bug.cgi?id=746668

11 years agox11/gl: Do not call glEnable/glDisable with GL_TEXTURE_2D
Emmanuele Bassi [Mon, 23 Mar 2015 22:03:00 +0000 (22:03 +0000)]
x11/gl: Do not call glEnable/glDisable with GL_TEXTURE_2D

These are fixed pipeline functions, and Mesa will warn (if debugging
messages are enabled). At best, they are poinless calls.

11 years agoUpdated Basque language
Inaki Larranaga Murgoitio [Mon, 23 Mar 2015 21:23:30 +0000 (22:23 +0100)]
Updated Basque language

11 years agoUpdated Basque language
Inaki Larranaga Murgoitio [Mon, 23 Mar 2015 21:22:39 +0000 (22:22 +0100)]
Updated Basque language

11 years agoUpdated Basque language
Inaki Larranaga Murgoitio [Mon, 23 Mar 2015 21:19:10 +0000 (22:19 +0100)]
Updated Basque language

11 years agoFix a minor typo in translatable string
Piotr Drąg [Mon, 23 Mar 2015 16:35:41 +0000 (17:35 +0100)]
Fix a minor typo in translatable string

11 years agoUpdated Polish translation
Piotr Drąg [Mon, 23 Mar 2015 16:33:05 +0000 (17:33 +0100)]
Updated Polish translation

11 years agoUpdated POTFILES.in and POTFILES.skip
Piotr Drąg [Mon, 23 Mar 2015 16:25:55 +0000 (17:25 +0100)]
Updated POTFILES.in and POTFILES.skip

11 years agoUpdated Czech translation
Marek Černocký [Mon, 23 Mar 2015 15:15:57 +0000 (16:15 +0100)]
Updated Czech translation

11 years agocsd: Fix an oversight for popups
Matthias Clasen [Mon, 23 Mar 2015 14:39:32 +0000 (10:39 -0400)]
csd: Fix an oversight for popups

After the recent rework of client-side shadow code, menus,
tooltips and similar popups were ending up with solid decorations.
Fix this oversight.

11 years agoUpdated Hungarian translation
Balázs Úr [Mon, 23 Mar 2015 14:40:53 +0000 (14:40 +0000)]
Updated Hungarian translation

11 years agoUpdate properties Hebrew translation
Yosef Or Boczko [Mon, 23 Mar 2015 12:53:57 +0000 (14:53 +0200)]
Update properties Hebrew translation

11 years agoUpdated Hebrew translation
Yosef Or Boczko [Mon, 23 Mar 2015 12:52:42 +0000 (14:52 +0200)]
Updated Hebrew translation

11 years agoUpdated Greek translations
Tom Tryfonidis [Mon, 23 Mar 2015 09:59:24 +0000 (11:59 +0200)]
Updated Greek translations

11 years agoUpdated Italian translation
Milo Casagrande [Mon, 23 Mar 2015 07:29:55 +0000 (07:29 +0000)]
Updated Italian translation

11 years agoUpdated Italian translation
Milo Casagrande [Mon, 23 Mar 2015 07:25:57 +0000 (07:25 +0000)]
Updated Italian translation

11 years agoStop using GDK_POINTER_MOTION_HINT_MASK in widgets
Matthias Clasen [Sun, 22 Mar 2015 04:49:16 +0000 (00:49 -0400)]
Stop using GDK_POINTER_MOTION_HINT_MASK in widgets

It is deprecated and no longer needed, and,as observed in
https://bugzilla.gnome.org/show_bug.cgi?id=746253 it
interferes with turning off event compression.

11 years agoSilence another compiler warning
Matthias Clasen [Sun, 22 Mar 2015 19:20:43 +0000 (15:20 -0400)]
Silence another compiler warning

Again, our habit of comparing enum values against -1.

11 years agoDon't return G_TYPE_INVALID as a pointer
Matthias Clasen [Sun, 22 Mar 2015 19:19:59 +0000 (15:19 -0400)]
Don't return G_TYPE_INVALID as a pointer

Use NULL for g_return_val_if_fail checks if the function returns
a pointer. Pointed out by clang.

11 years agotext view: Avoid clang compiler warnings
Matthias Clasen [Sun, 22 Mar 2015 19:19:17 +0000 (15:19 -0400)]
text view: Avoid clang compiler warnings

Again, our habit to use -1 as an unset value for enum types.

11 years agoRemove a redundant const
Matthias Clasen [Sun, 22 Mar 2015 19:18:35 +0000 (15:18 -0400)]
Remove a redundant const

const gchar const is still just const gchar, unless there's
indirections in between.

11 years agocss: Silence a clang warning
Matthias Clasen [Sun, 22 Mar 2015 19:17:27 +0000 (15:17 -0400)]
css: Silence a clang warning

Clang complains that this check can never be true. Since this
is a argument range check which we do to catch bad input,
convince clang to not complain instead of taking it out.

11 years agoRemove a pointless comparison
Matthias Clasen [Sun, 22 Mar 2015 19:16:14 +0000 (15:16 -0400)]
Remove a pointless comparison

Comparing an unsigned value against < 0 is not going to succeed.
Pointed out by clang.

11 years agopaper size: Don't use abs() on floats
Matthias Clasen [Sun, 22 Mar 2015 19:15:42 +0000 (15:15 -0400)]
paper size: Don't use abs() on floats

Use fabs() instead. Pointed out by clang.

11 years agoMore of the same
Matthias Clasen [Sun, 22 Mar 2015 19:14:42 +0000 (15:14 -0400)]
More of the same

A similar case in GtkIconHelper. Here we were confusing ourselves,
and compared a icon_size against -1, although the variable is
never set to -1.

11 years agoAvoid some clang compiler warnings
Matthias Clasen [Sun, 22 Mar 2015 19:12:30 +0000 (15:12 -0400)]
Avoid some clang compiler warnings

Avoid some compiler warnings from clang in deprecated code.
Most of these are around our habit of using -1 as an 'unset'
value for enumerations.

11 years agoFix some clang warnings
Matthias Clasen [Sun, 22 Mar 2015 18:40:57 +0000 (14:40 -0400)]
Fix some clang warnings

It complains about double const, and it is right.

11 years agoMake the blur code compile with clang
Matthias Clasen [Sun, 22 Mar 2015 17:48:02 +0000 (13:48 -0400)]
Make the blur code compile with clang

clang complains that the expression involving sqrt() is not
constant, and thus refuses to accept it as a case label. So,
use precomputed values instead.

https://bugzilla.gnome.org/show_bug.cgi?id=746468

11 years agoFix the build
Matthias Clasen [Sun, 22 Mar 2015 15:55:33 +0000 (11:55 -0400)]
Fix the build

11 years agotooltip: Minor cleanup
Matthias Clasen [Sun, 22 Mar 2015 15:47:23 +0000 (11:47 -0400)]
tooltip: Minor cleanup

Preserve the symmetry in gtk_tooltip_set_last_window.

11 years agosearch bar: Clean up weak pointer handling
Matthias Clasen [Sun, 22 Mar 2015 15:46:16 +0000 (11:46 -0400)]
search bar: Clean up weak pointer handling

Break out a setter that manages the weak pointer, and
use it in finalize. This also fixes a bug where we were
forgetting to disconnect the right signal handler in
some cases.

11 years agomount operation: Minor formatting cleanup
Matthias Clasen [Sun, 22 Mar 2015 15:45:19 +0000 (11:45 -0400)]
mount operation: Minor formatting cleanup

The pattern for g_object_add_weak_pointer calls is to
have the same expression in both arguments.

11 years agomenu button: Minor cleanup
Matthias Clasen [Sun, 22 Mar 2015 15:44:37 +0000 (11:44 -0400)]
menu button: Minor cleanup

Preserve the symmetry in set_align_widget_pointer.

11 years agoClean up some unfortunate formatting
Matthias Clasen [Sun, 22 Mar 2015 15:44:00 +0000 (11:44 -0400)]
Clean up some unfortunate formatting

"if (...) do" just looks wrong.

11 years agodnd: Introduce a helper to manage the weak pointer
Matthias Clasen [Sun, 22 Mar 2015 15:13:08 +0000 (11:13 -0400)]
dnd: Introduce a helper to manage the weak pointer

Introduce a setter that takes care of updating the weak ref
whenever we assign info->widget. Just a cleanup of the previous patch.

11 years agoDND: Clean up weak pointers when they are no longer needed
Tom Hughes [Sun, 22 Mar 2015 10:55:00 +0000 (10:55 +0000)]
DND: Clean up weak pointers when they are no longer needed

Failure to do so leads to memory corruption down the road.
This was introduced in commit 650c25e06c17.

https://bugzilla.gnome.org/show_bug.cgi?id=746602

11 years agoUpdated German translation
Christian Kirbach [Sun, 22 Mar 2015 11:07:20 +0000 (11:07 +0000)]
Updated German translation

11 years agoUpload Catalan translation
Jordi Mas [Sun, 22 Mar 2015 08:18:27 +0000 (04:18 -0400)]
Upload Catalan translation

11 years agoAdd an index for new api to the docs
Matthias Clasen [Sun, 22 Mar 2015 06:11:03 +0000 (02:11 -0400)]
Add an index for new api to the docs

11 years agoradio-menu-item: Add join_group()
Matthias Clasen [Sun, 22 Mar 2015 05:57:57 +0000 (01:57 -0400)]
radio-menu-item: Add join_group()

The other Radio* widgets have this convenience method that removes the
memory management of the opaque GSList used to handle the group from the
API usable from language bindings (especially the ones not based on
introspection).

This commit adds gtk_radio_menu_item_join_group().

https://bugzilla.gnome.org/show_bug.cgi?id=671362

11 years agoradio-menu-item: Allow arguments to be NULL
Matthias Clasen [Sun, 22 Mar 2015 05:54:08 +0000 (01:54 -0400)]
radio-menu-item: Allow arguments to be NULL

Some arguments, like the group and the label of a RadioMenuItem, can be
NULL: the RadioMenuItem has all the code to deal with them. The argument
validation is too strict, though, for instance doing:

  return_if_fail (IS_RADIO_MENU_ITEM (foo))

  if (foo != NULL)
    set_foo (foo)

Which is obviously incorrect.

This commit also modifies the annotations of the API, to ensure that
language bindings do the right thing.

https://bugzilla.gnome.org/show_bug.cgi?id=671362

11 years agoradio-menu-item: Handle a !NULL group
Emmanuele Bassi [Mon, 5 Mar 2012 13:09:47 +0000 (13:09 +0000)]
radio-menu-item: Handle a !NULL group

If we create a RadioMenuItem without a group, and then set a group, the
menu item will still be set as active, which means an inconsistently
drawn radio menu item - as the RadioMenuItem will set the active flag on
itself, but then it won't reset it when it gets a new group.

https://bugzilla.gnome.org/show_bug.cgi?id=671362

11 years agoStart 3.17 development
Matthias Clasen [Sun, 22 Mar 2015 06:00:04 +0000 (02:00 -0400)]
Start 3.17 development

Bump the version to 3.17.0 and add version macros.

11 years agoImprove CSD decorations without a compositor
Olivier Fourdan [Wed, 11 Mar 2015 12:52:21 +0000 (13:52 +0100)]
Improve CSD decorations without a compositor

It turned out that using mwm hints to instruct wms to
create border-only decorations is not really working
universally. So, instead of doing this, render a solid
frame without shadow on the client-side to handle this
case.

https://bugzilla.gnome.org/show_bug.cgi?id=746222

Signed-off-by: Olivier Fourdan <fourdan@xfce.org>
11 years agoimage: Optimize non-resize changes
Matthias Clasen [Sat, 31 Jan 2015 04:32:50 +0000 (23:32 -0500)]
image: Optimize non-resize changes

When the image content is changed, only queue a resize
if the size is actually changing, otherwise just a
redraw. Suggested by Owen in

https://bugzilla.gnome.org/show_bug.cgi?id=613833

11 years agoa11y: handle atk race condition where widget has been destroyed
Christian Hergert [Sat, 21 Mar 2015 21:17:39 +0000 (14:17 -0700)]
a11y: handle atk race condition where widget has been destroyed

If the widget has been destroyed since a DBus message had been sent,
we could be in a condition that the widget pointer exists but it does
not have a window.

This bails as if the widget didn't exist if there is no available
GdkWindow.

We also set the extents to 0 to be defensive since this is a vfunc
implementation.

https://bugzilla.gnome.org/show_bug.cgi?id=746586

11 years agoUpdated Turkish translation
Muhammet Kara [Sat, 21 Mar 2015 21:25:38 +0000 (21:25 +0000)]
Updated Turkish translation

11 years agobox-shadow: For top/bottom and left/right parts, repeat a single line
Alexander Larsson [Fri, 20 Mar 2015 13:56:42 +0000 (14:56 +0100)]
box-shadow: For top/bottom and left/right parts, repeat a single line

Since these part really are the same in all of the x or y direction
and we don't blur in that direction we can just blur one line and
repeat it during drawing.

https://bugzilla.gnome.org/show_bug.cgi?id=746468

11 years agoshadow-box: Blur only horizontally/vertically for the non-corner parts
Alexander Larsson [Fri, 20 Mar 2015 13:34:44 +0000 (14:34 +0100)]
shadow-box: Blur only horizontally/vertically for the non-corner parts

There is no need to e.g. blur in the x-direction for the top part
of a box shadow. Also, there is no need to extend the mask in the
non-blurred direction.

https://bugzilla.gnome.org/show_bug.cgi?id=746468

11 years agoshadow-box: Bail out blur early if radius is 1px
Alexander Larsson [Fri, 20 Mar 2015 13:31:57 +0000 (14:31 +0100)]
shadow-box: Bail out blur early if radius is 1px

For radius 1px the current implementation rounds down to a 1 px box
filter which is a no-op. Rather than creating useless shadow masks
in this case we bail out blurring early.

Another alternative would be to make radius 1px round up to a 2 px box
filter, but that would change the rendering of Adwaita which is probably
not a great idea this late in the cycle.

https://bugzilla.gnome.org/show_bug.cgi?id=746468

11 years agogtkcairoblur: Unroll inner loop for common radius values
Alexander Larsson [Thu, 19 Mar 2015 15:29:32 +0000 (16:29 +0100)]
gtkcairoblur: Unroll inner loop for common radius values

This unrolls the inner blur loop for radius 1-10, allowing
the compiler to use a divide-by-constant operation instead
of a generic division.

Here is the blur-performance output before:

Radius  1: 124.95 msec, 32.01 kpixels/msec:
Radius  2: 117.27 msec, 34.11 kpixels/msec:
Radius  3: 123.57 msec, 32.37 kpixels/msec:
Radius  4: 118.17 msec, 33.85 kpixels/msec:
Radius  5: 119.32 msec, 33.52 kpixels/msec:
Radius  6: 124.17 msec, 32.21 kpixels/msec:
Radius  7: 121.04 msec, 33.05 kpixels/msec:
Radius  8: 130.64 msec, 30.62 kpixels/msec:
Radius  9: 119.47 msec, 33.48 kpixels/msec:
Radius 10: 117.95 msec, 33.91 kpixels/msec:
Radius 11: 122.38 msec, 32.68 kpixels/msec:
Radius 12: 121.92 msec, 32.81 kpixels/msec:
Radius 13: 125.45 msec, 31.89 kpixels/msec:
Radius 14: 121.63 msec, 32.89 kpixels/msec:
Radius 15: 120.18 msec, 33.28 kpixels/msec:

And after:

Radius  1: 42.26 msec, 94.65 kpixels/msec:
Radius  2: 59.15 msec, 67.62 kpixels/msec:
Radius  3: 60.29 msec, 66.35 kpixels/msec:
Radius  4: 64.53 msec, 61.99 kpixels/msec:
Radius  5: 60.07 msec, 66.59 kpixels/msec:
Radius  6: 62.43 msec, 64.07 kpixels/msec:
Radius  7: 60.36 msec, 66.27 kpixels/msec:
Radius  8: 59.59 msec, 67.13 kpixels/msec:
Radius  9: 76.17 msec, 52.51 kpixels/msec:
Radius 10: 79.41 msec, 50.37 kpixels/msec:
Radius 11: 118.92 msec, 33.64 kpixels/msec:
Radius 12: 121.31 msec, 32.97 kpixels/msec:
Radius 13: 118.30 msec, 33.81 kpixels/msec:
Radius 14: 116.82 msec, 34.24 kpixels/msec:
Radius 15: 116.99 msec, 34.19 kpixels/msec:

I.e. almost double performance for the unrolled radius values.

https://bugzilla.gnome.org/show_bug.cgi?id=746468

11 years agogtkcairoblur: Minor restructure
Alexander Larsson [Thu, 19 Mar 2015 15:25:25 +0000 (16:25 +0100)]
gtkcairoblur: Minor restructure

This just moves get_box_filter_size to the top and makes
it a macro (so it can be used as a constant later).

https://bugzilla.gnome.org/show_bug.cgi?id=746468

11 years agoAdd performance test for gtkcairoblur
Alexander Larsson [Thu, 19 Mar 2015 15:24:19 +0000 (16:24 +0100)]
Add performance test for gtkcairoblur

This just creates a large cairo surface and times bluring it
at various values of radius.

https://bugzilla.gnome.org/show_bug.cgi?id=746468

11 years agoUpdated Dutch translation gtk and gtk-properties master 3.16
hanniedu [Sat, 21 Mar 2015 17:25:17 +0000 (18:25 +0100)]
Updated Dutch translation gtk and gtk-properties master 3.16

11 years agoHighContrast: Fix a typo
Matthias Clasen [Sat, 21 Mar 2015 00:48:25 +0000 (20:48 -0400)]
HighContrast: Fix a typo

Commit 0a39d7d9 introduced a selected_bg_color with a missing $
in front of it.

11 years agoUpdated Hungarian translation
Gábor Kelemen [Fri, 20 Mar 2015 23:23:24 +0000 (23:23 +0000)]
Updated Hungarian translation

11 years agoUpdated Hungarian translation
Balázs Úr [Fri, 20 Mar 2015 22:57:03 +0000 (22:57 +0000)]
Updated Hungarian translation

11 years agoreftests: Add a way to compare different runs
Matthias Clasen [Fri, 20 Mar 2015 20:39:36 +0000 (16:39 -0400)]
reftests: Add a way to compare different runs

gtk-reftest already had an --output=DIR option to tell it where
to save all the resulting images. Now you can combine this with
the --compare-with=DIR option in a second run to make gtk-reftest
compare the .out.png files from the first run with the .out.png
files of the current run, instead of producing .ref.png files.

The intended use for this is to verify that changes do not affect
the generated output.

11 years agomir: Fix version annotation, the mir-backend is available since 3.16
Rico Tzschichholz [Fri, 20 Mar 2015 19:18:44 +0000 (20:18 +0100)]
mir: Fix version annotation, the mir-backend is available since 3.16